{AKS-Preview} Remove DATA_STORAGE references#9110
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
Bot
requested review from
FumingZhang,
yanzhudd,
yonzhan and
zhoxing-ms
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated DATA_STORAGE references from the aks-preview extension and updates the version number. The changes modernize the storage account SAS token generation by replacing the old CloudStorageAccount approach with the newer generate_account_sas method.
- Updates extension version from 18.0.0b29 to 18.0.0b30
- Refactors storage account SAS token generation to use newer Azure SDK methods
- Removes deprecated _cloud_storage_account_service_factory function
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/aks-preview/setup.py | Version bump to 18.0.0b30 |
| src/aks-preview/azext_aks_preview/aks_diagnostics.py | Replaces deprecated DATA_STORAGE CloudStorageAccount with DATA_STORAGE_BLOB generate_account_sas |
| src/aks-preview/HISTORY.rst | Adds changelog entry for DATA_STORAGE references removal |
|
|
please resolve merge conflict |
…storage-track1 # Conflicts: # src/aks-preview/HISTORY.rst
|
@FumingZhang please help review again. |
|
[Release] Update index.json for extension [ aks-preview-18.0.0b31 ] : https://dev.azure.com/msazure/One/_build/results?buildId=135647014&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.